From: | alexis(at)m2osw(dot)com |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #1490: contrib .sql.in sed command bogus |
Date: | 2005-02-22 06:27:47 |
Message-ID: | Pine.LNX.4.44.0502212227110.11342-100000@substitute |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Hi Tom,
Indeed, with the correct version the $libdir will work in the .sql file.
Very good. 8-)
Alexis
On Mon, 21 Feb 2005, Tom Lane wrote:
> "Alexis Wilke" <alexis(at)m2osw(dot)com> writes:
> > Inside pgxs.mk I had to change the $$libdir into $(libdir ) to get the
> > proper path in the final .sql file:
>
>
> > ifneq (,$(MODULES)$(MODULE_big))
> > %.sql: %.sql.in
> > sed 's,MODULE_PATHNAME,$(libdir)/$*,g' $< >$@
> > endif
>
> This is not correct --- the substitution is supposed to be literally
> "$libdir", and so the makefile is correct as-is. (I'm not sure why we
> still bother with doing the sed conversion at all, except that if we
> removed it you can be sure we'd think of some other thing we needed it
> for ;-))
>
> regards, tom lane
>
From | Date | Subject | |
---|---|---|---|
Next Message | alexis | 2005-02-22 06:29:31 | Re: BUG #1491: Getting an "undefined symbol" when loading |
Previous Message | Barry Brown | 2005-02-22 00:55:37 | BUG #1498: Default permissions allow any user to create objects in any database (revised) |