Re: introduce "default_use_oids"

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Manfred Koizar <mkoi-pg(at)aon(dot)at>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: introduce "default_use_oids"
Date: 2003-12-01 06:18:23
Message-ID: Pine.LNX.4.44.0312010717570.22012-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian writes:

> Your patch has been added to the PostgreSQL unapplied patches list at:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches
>
> I will try to apply it within the next 48 hours.

This parameter ought to be called "default_with_oids", to reflect the
actual effect.

>
> ---------------------------------------------------------------------------
>
>
> Neil Conway wrote:
> > On Fri, 2003-10-10 at 05:56, Manfred Koizar wrote:
> > > On Tue, 30 Sep 2003 20:00:22 -0400, Neil Conway <neilc(at)samurai(dot)com>
> > > wrote:
> > > >This patch adds a new GUC var, "default_use_oids"
> > >
> > > Shouldn't it be honoured by CREATE TABLE AS SELECT ... ?
> >
> > Good catch. I've attached an updated patch. I also included a few
> > improvements to the docs.
> >
> > I think it would be a good idea to extend CREATE TABLE AS to allow WITH
> > OIDS and WITHOUT OIDS to be specified, so that it provides a better
> > option for people who need OIDs in their CREATE TABLE AS-generated
> > tables than manually setting the default_use_oids GUC var (CREATE TABLE
> > AS should also accept ON COMMIT ..., for that matter). But implementing
> > this will require changing the internal representation of CREATE TABLE
> > AS to be something more than just a wrapper over SelectStmt, I believe.
> > I haven't made this change in the attached patch, but I'll probably do
> > it before 7.5 is released. Any comments?
> >
> > -Neil
> >
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 8: explain analyze is your friend
>
>

--
Peter Eisentraut peter_e(at)gmx(dot)net

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2003-12-01 06:20:21 Re: ISO 8601 "Time Intervals" of the "format with time-unit
Previous Message Tom Lane 2003-12-01 06:11:27 Re: export FUNC_MAX_ARGS as a read-only GUC variable