From: | Dennis Bjorklund <db(at)zigo(dot)dhs(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Function parameter names |
Date: | 2003-11-25 18:27:58 |
Message-ID: | Pine.LNX.4.44.0311251921220.29118-100000@zigo.dhs.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, 23 Nov 2003, Tom Lane wrote:
> Actually I'd suggest text[], as there is no good reason to pad the
> array entries to a fixed length.
I've implemented this part now and it stores the paremeter names in the
pg_proc table as a text[] field.
However, in the parser I use IDENT to get the parameter names and already
in the lexer the IDENT tokens are truncated to length NAMEDATALEN.
So I've got 3 options:
1) Leave it as is now where the system table allows any length
but the parser only lets you insert "short" identifiers.
2) Change the type to name[]
3) Change the parser to accept identifiers of any length and add
the length check in a later phase for the identifiers that need
to be shorter.
Any opinions or should I just make a choice myself?
--
/Dennis
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-11-25 18:36:50 | Re: [HACKERS] Commercial binary support? |
Previous Message | Kurt Roeckx | 2003-11-25 18:13:36 | Re: A rough roadmap for internationalization fixes |