| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | ViSolve Open Source Team <opensrc_support_hp(at)visolve(dot)com> |
| Cc: | pgsql-bugs(at)postgresql(dot)org, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for HP-UX |
| Date: | 2003-11-25 14:37:51 |
| Message-ID: | Pine.LNX.4.44.0311251535360.11097-100000@peter.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
ViSolve Open Source Team writes:
> 1. s_lock.h: modified with inline tas code for the HP-C compiler
What is this line all about?
+#if defined(__HP_aCC) || defined(__HP_cc)
There are no other compilers supported, so this seems redundant.
> 2. genbki.sh: a one-line change that fixes a string concatenation problem with the
> HP-C compiler (specific to included .c files).
You're doing this:
-TMPFILE="$TMPDIR/genbkitmp$$.c"
+TMPFILE="$TMPDIR/genbkitmp$$.h"
I'm afraid this will not fly, because calling the preprocessor is only
portable on .c files. Generally, it's also unwise to rely in this kind of
subtle side effect. We need a general solution.
--
Peter Eisentraut peter_e(at)gmx(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Ward | 2003-11-25 17:37:07 | 7.4RC2 PANIC: insufficient room in FSM |
| Previous Message | Seum-Lim Gan | 2003-11-25 03:29:37 | Re: Fwd: Solaris build of 7.4 problem with |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-11-25 16:24:01 | Re: minor cleanup in plpgsql.sgml |
| Previous Message | Robert Treat | 2003-11-25 14:18:21 | minor cleanup in plpgsql.sgml |