Re: [COMMITTERS] pgsql-server/src Makefile.global.in makefiles/ ...

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, <Bill(dot)Allie(at)mug(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src Makefile.global.in makefiles/ ...
Date: 2002-11-28 23:32:57
Message-ID: Pine.LNX.4.44.0211281951390.12428-100000@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

This patch needs to be reverted. It causes the compilation environment
seen by the makefiles to be different from what is dealt with in
configure, which creates a recipe for desaster. If additional "rpaths"
are to be added to the linker flags, it needs to be done in configure
before any tests that invoke the linker.

As a side note, I would even question that the patch as it stands is
generally useful: Consider the case that one has libraries in the
non-standard directories that are now covered by the additional rpath
flags. How could configure even produce reliable results if it doesn't
have access to those presumably relevant libraries?

Bruce Momjian writes:

>
> OK, Peter, here is Billie's patch.
>
> ---------------------------------------------------------------------------
>
> Peter Eisentraut wrote:
> > Bruce Momjian writes:
> >
> > > OK, how do we proceed?
> >
> > To be honest, I haven't even seen the patch yet, only a description. I
> > can't find the actual patch in my local mailboxes or in the archives on
> > the web. The idea sounds right and it should be expanded to all
> > platforms, but it needs to be considered carefully. Rpaths are awfully
> > messy.
> >
> > > If we back it out, how does Billy get this working for his system?
> >
> > The same way everybody else does.
> >
> > --
> > Peter Eisentraut peter_e(at)gmx(dot)net
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> >
>
>

--
Peter Eisentraut peter_e(at)gmx(dot)net

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2002-11-29 01:58:00 Re: [COMMITTERS] pgsql-server/src Makefile.global.in makefiles/
Previous Message Bruce Momjian - CVS 2002-11-28 20:05:13 pgsql-server/doc/TODO.detail trigger

Browse pgsql-patches by date

  From Date Subject
Next Message Nigel Kukard 2002-11-29 01:14:14 postgresql 7.3 + IPv6 patch
Previous Message Fernando Nasser 2002-11-28 19:08:29 Re: Hierarchical queries a la Oracle. Patch.