Re: DROP COLUMN misbehaviour with multiple inheritance

From: Alvaro Herrera <alvherre(at)atentus(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hannu Krosing <hannu(at)tm(dot)ee>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DROP COLUMN misbehaviour with multiple inheritance
Date: 2002-09-12 14:41:49
Message-ID: Pine.LNX.4.44.0209121040010.3954-100000@cm-lcon1-46-187.cm.vtr.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane dijo:

> Hannu Krosing <hannu(at)tm(dot)ee> writes:
> > I've come upon a misbehaviour of drop column, where drop column
> > unconditionally drops inherited column from child tables.
> > What it should do is to check if the same column is not inherited from
> > other parents and drop it only when it is not
>
> Hm. Seems like attisinherited should have been a count, not a boolean.

I'll try to make a fix and submit.

> Is anyone sufficiently excited about this issue to force an initdb to
> fix it?

If people thinks it's important, the fix can be integrated. If not, it
can wait until 7.4.

--
Alvaro Herrera (<alvherre[a]atentus.com>)
"Aprende a avergonzarte mas ante ti que ante los demas" (Democrito)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-09-12 14:41:53 Re: DROP COLUMN misbehaviour with multiple inheritance
Previous Message Tom Lane 2002-09-12 14:31:00 Re: OPAQUE and 7.2-7.3 upgrade

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-09-12 14:41:53 Re: DROP COLUMN misbehaviour with multiple inheritance
Previous Message Tom Lane 2002-09-12 14:35:49 Re: Earth Distance patch