Re: pg_dump output portability

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump output portability
Date: 2002-08-15 19:29:56
Message-ID: Pine.LNX.4.44.0208152126500.20055-100000@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane writes:

> Ah. But where exactly will you substitute true for 't'? I don't think
> pg_dump necessarily knows enough to apply that transformation.

Sure, it does it already for other types. Look for BITOID in pg_dump.c.

> Switching the default is definitely fine with me, but I'd lean towards
> ripping it out entirely, given that the backend-supplied chunks of stuff
> are not going to have extra quotes. We always tell people "always quote
> or never quote" a given identifier; pg_dump scripts ought to follow that
> rule.

It occurred to me that pg_dump would need to know which names are
keywords. Ugh.

--
Peter Eisentraut peter_e(at)gmx(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2002-08-15 19:30:22 Re: pg_dump large file support
Previous Message Marc G. Fournier 2002-08-15 19:03:31 Re: failure notice (fwd)