From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Neil T(dot) Spring" <nspring(at)cs(dot)washington(dot)edu>, <pgsql-bugs(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org>, <143992(at)bugs(dot)debian(dot)org> |
Subject: | Re: [PATCHES] pg_dumpall should permit quiet operation |
Date: | 2002-06-23 21:49:55 |
Message-ID: | Pine.LNX.4.44.0206232235550.929-100000@localhost.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-patches |
Tom Lane writes:
> You seem to have missed the point completely - Neil wanted to suppress
> the normal progress messages *on stderr* so that he'd only get an email
> report when there was an abnormal event. That request seemed fine to
> me, though I thought the patch itself might have some portability
> issues. If it were recoded to follow the style of the existing boolean
> options in pg_dumpall then I'd recommend accepting it.
Two points:
1) The purpose of the progress messages is to inform the user of what
database he is connecting to. Previously, the user just got a prompt
"Password:" and had to guess which one. Unfortunately, it's hard for
pg_dumpall to predict whether a password prompt will appear.
This will become a nonissue soon because:
2) I'm currently rewriting pg_dumpall in C (as part of pg_dump actually),
so this patch will become obsolete.
(Also, I think we don't support external password files anymore, so the
password is now predictable and the progress messages can be removed, if
so.)
--
Peter Eisentraut peter_e(at)gmx(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | pgsql-bugs | 2002-06-24 07:33:39 | Bug #695: Wrong Timezone offset (like bug#672) |
Previous Message | Bruce Momjian | 2002-06-23 21:29:34 | Re: Patch for memory leaks in index scan |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2002-06-23 21:51:25 | Re: [PATCHES] PostgreSQL 7.2.1 and Sun's C compiler under |
Previous Message | Bruce Momjian | 2002-06-23 21:33:43 | Re: several minor cleanups |