| From: | Kris Jurka <books(at)ejurka(dot)com> |
|---|---|
| To: | Dave Cramer <pg(at)fastcrypt(dot)com> |
| Cc: | Alexey Yudichev <Alexey(at)francoudi(dot)com>, "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: FW: OID, compatible=7.1 and getBinaryStream() in |
| Date: | 2003-12-18 00:17:43 |
| Message-ID: | Pine.LNX.4.33.0312171910500.13414-300000@leary.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
On 17 Dec 2003, Dave Cramer wrote:
> patched and backpatched,
The test case you've added has some issues:
1) It has a fixed connection string instead of using the connection
parameters from TestUtil.
2) It prints output to standard out instead of using asserts
3) It has the original comments describing the bug which are confusing if
you expect the test to pass.
4) It uses windows end of line characters.
This patch fixes these issues.
Additionally doing some testing revealed another bug with compatibilty
version handling. If the user does not explicitly specify a "compatible"
parameter it defaults to the jdbc driver version. It should instead
default to the server version the connection is for because a newer driver
can talk to older databases.
I've attached a patch for this as well.
Kris Jurka
| Attachment | Content-Type | Size |
|---|---|---|
| setbinarystreamtest.patch | text/plain | 7.2 KB |
| compatlevel.patch | text/plain | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kris Jurka | 2003-12-18 00:20:23 | Missing patches on 7.4 branch. |
| Previous Message | Dave Cramer | 2003-12-17 15:49:12 | Re: FW: OID, compatible=7.1 and getBinaryStream() in |