From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Ian Lance Taylor <ian(at)airs(dot)com> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Support building in a different directory on Solaris |
Date: | 2001-09-11 00:13:23 |
Message-ID: | Pine.LNX.4.30.0109110144170.680-100000@peter.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Ian Lance Taylor writes:
> Note that this patch normally will not run prep_buildtree on top of
> the source tree. That would only happen in exceptional circumstances
> in which /bin/pwd did not return the same string in the same
> directory. I wrote the patch to address Tom Lane's suggestion of not
> requiring test to support the relatively new -ef option.
I've thought hard about this and the solution that satisfied me most was
that
test $srcdir -ef . || test `cd $srcdir && /bin/pwd` = `/bin/pwd`
(properly quoted etc.) means srcdir == builddir. That means on Solaris
you will invoke the second part, as you suggested in your patch, whereas
if test -ef works you'll get the safer alternative.
I've also installed your prep_buildtree patch to be on the safe side.
One of my concerns is that prep_buildtree isn't super-portable by design
(using 'find'), but we'll just have to cross our fingers that nobody
exercises all these unlikely cases.
--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter
From | Date | Subject | |
---|---|---|---|
Next Message | Kenji Sugita | 2001-09-11 00:20:33 | Re: Configuring fdatasync for Solaris2 |
Previous Message | Jeroen van Vianen | 2001-09-10 18:00:39 | Fix for broken JDBC's getColumn() (take 2) |