Re: pgindent run?

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run?
Date: 2001-03-22 16:12:59
Message-ID: Pine.LNX.4.30.0103221709030.1208-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian writes:

> > >> Are there any severely mis-indented files?
> >
> > There are some new contrib modules that are nowhere close to our
> > indent conventions; also a good deal of foreign-key-related stuff
> > in the parser that needs to be cleaned up. So we should run it.
> >
> > I've always felt that it'd be smarter to run pgindent at the start
> > of a development cycle, not the end, but I've been unable to convince
> > Bruce of that ...
>
> Hey, I am open to whatever people want to do. Just remember that we
> accumulate lots of patches/development during the slow time before
> development, and those patches become harder to apply. Peter E has some
> already.

This argument seems irrelevant when given the choice of before release or
after start of new cycle. From an analytical point of view (and slightly
idealized), these are limits approaching the same points in time, from
opposite sides. Thus, the second choice seems the infinitely better
option.

--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-03-22 16:14:23 Re: pgindent run?
Previous Message Bruce Momjian 2001-03-22 16:12:04 Re: pgindent run?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-03-22 16:14:23 Re: pgindent run?
Previous Message Bruce Momjian 2001-03-22 16:12:04 Re: pgindent run?