| From: | "Nigel J(dot) Andrews" <nandrews(at)investsystems(dot)co(dot)uk> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Use of 'cp -r' in CREATE DATABASE |
| Date: | 2003-12-12 00:45:21 |
| Message-ID: | Pine.LNX.4.21.0312120043590.27785-100000@ponder.fairway2k.co.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 11 Dec 2003, Alvaro Herrera wrote:
> On Thu, Dec 11, 2003 at 06:36:05PM -0500, Bruce Momjian wrote:
> > Our dbcommands.c has for create database:
> >
> > snprintf(buf, sizeof(buf), "cp -r '%s' '%s'", src_loc, target_dir);
> >
> [...]
> >
> > I think we should switch to -R in our code.
>
> But you will have to write special code for Win32, won't you?
> Maybe it would be better to avoid using system commands
> altogether and copy the whole thing using syscalls ...
That was my immediate thought. Unfortunately that means reinventing the
wheel; or grabbing it from BSD or somewhere and distributing it with
postgresql.
--
Nigel J. Andrews
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-12-12 01:05:54 | Re: Use of 'cp -r' in CREATE DATABASE |
| Previous Message | Timothy D. Witham | 2003-12-12 00:10:41 | Re: [Stp-devel] DBT-2 running against PostgreSQL and LVM2 |