From: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: fix broken regression tests |
Date: | 2003-01-15 22:28:35 |
Message-ID: | Pine.LNX.4.21.0301160926130.3772-100000@linuxworld.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On Wed, 15 Jan 2003, Tom Lane wrote:
> Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > On Wed, 15 Jan 2003, Tom Lane wrote:
> >> Ugh, that's bad news. Can we lobby the bison folks to revert this
> >> random rewording of an error message? Or at least make it configurable,
> >> so that we can avoid exposing any change to our users?
>
> > The change doesn't seem to be for trivial reasons. Log message for
> > revision 1.35 of data/yacc.c says:
> > "parse error" -> "syntax error" for POSIX compatibility.
>
> Grumble. That probably means they'll reject any complaints about it.
Yep. That's why I brought it up.
>
> My inclination at this point is to do sed 's/syntax error/parse error/'
> in our grammar build rules so as to maintain backwards compatibility.
How about we do that for 7.4 with a mention in the release notes / manual
that 'syntax error' will release 'parse error' in some future
release. Then again, isn't their a planned overhaul of error handling
for 7.4 to bring it into line with SQL? If so, a change to parse error
messages is the smallest problem facing users.
Gavin
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2003-01-15 23:15:14 | replace oidrand() with random_sample() |
Previous Message | Rod Taylor | 2003-01-15 21:21:54 | Re: ALTER TABLE .. SET WITHOUT OIDS -- ROUND 2 |