From: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mike Mascari <mascarm(at)mascari(dot)com> |
Subject: | Re: ON COMMIT temp table handling |
Date: | 2002-11-25 02:17:49 |
Message-ID: | Pine.LNX.4.21.0211251314080.27870-100000@linuxworld.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Thanks Bruce,
I've been in France/Germany and haven't had internet access :-(. Hence
slow response, below.
On Sat, 9 Nov 2002, Bruce Momjian wrote:
> o The code has drifted since last August, so I had to apply
> some of it by hand.
Thanks.
> o Your code in cluster.c called heap_create_with_catalog() using:
>
> isTempNamespace(RelationGetNamespace(OldHeap)),
>
> which returns a boolean, and passes it as the value for 'ateoxact',
> which is not a boolean. This call is used to create the new heap file
> for the cluster operation. I changed it to ATEOXACTNOOP.
I haven't looked at the patch because its a bit chaotic here after getting
back, but it occurs to me that if the cluster is on a temp table we want
to tell heap_create_with_catalog().
>
> o Your handling of the temprels List was incorrect. You can't use
> foreach() to traverse a List when you are removing entries from the
> list. (The loop variable pointer is removed and causes havoc.) I
> changed the loop to while() and added the necessary loop control
> statements. I thought you used my temprel.c code for this. It had the
> proper control statements. Did you remove them by mistake:
>
> http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/cache/Attic/temprel.c
I must have. Oops.
Gavin
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-11-25 02:41:44 | Re: ON COMMIT temp table handling |
Previous Message | Masaru Sugawara | 2002-11-24 04:26:32 | Re: quote_ident and schemas (was Re: connectby with schema) |