| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: UUNET socket-file-location patch |
| Date: | 2000-11-15 16:38:12 |
| Message-ID: | Pine.LNX.4.21.0011151736160.779-100000@peter.localdomain |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian writes:
> > Hmm. I think it would make more sense to make the parameter be just
> > the directory, not the full path including filename --- for one thing,
> > doing it like that renders the port-number parameter useless. Why not
> >
> > #define UNIXSOCK_PATH(sun,port,defpath) \
> > snprintf((sun).sun_path, sizeof((sun).sun_path), "%s/.s.PGSQL.%d", \
> > (((defpath) && *(defpath) != '\0') ? (defpath) : "/tmp"), \
> > (port))
>
> I can do that. Of course, I have to now change all the documentation to
> match it. :-)
Rather:
#define UNIXSOCK_PATH(sun,port,defpath) \
snprintf((sun).sun_path, sizeof((sun).sun_path), "%s/.s.PGSQL.%d", \
(defpath), (port))
and make "/tmp" the default in guc.c.
--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2000-11-15 16:42:43 | Re: Re: UUNET socket-file-location patch |
| Previous Message | Bruce Momjian | 2000-11-15 14:15:50 | Re: Re: UUNET socket-file-location patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2000-11-15 16:42:43 | Re: Re: UUNET socket-file-location patch |
| Previous Message | Peter Eisentraut | 2000-11-15 16:31:42 | Re: Syslog Facility Patch |