Re: pgxs: build infrastructure for extensions v4

Dear peter,

> > Please find attached another new version of a patch which provides a
> > working infrastructure for pg extensions. I hope it addresses all of
> > Peter's comments. I'll be away for the next 3 weeks, so if minor
> > changes are required it would be best if you could proceed without
> > me...
>
> This patch breaks building outside the source tree in a very elaborate
> and obvious way. Unfortunately, this is all tied together so I haven't
> figured out yet if it can be fixed easily.

I do not get your point. the aim is to be able to build outside the source
tree as well?

> Also, the use of the install targets is a bit strange
> (install-all-headers install libpgport.a). I would simply not bother
> and install everything all the time. However, those who advocate the
> install-all-headers target may want to propose a different scheme.

part of this existed before the patch. I tried to make the best of
existing targets, especially as you requested that less targets should be
used. I do agree with you that installing libgport.a under
install-all-headers looks stupid, but the idea behind all-headers is that
all which is required for extensions is installed.

What about install-dev-files? or anything less misleading?

> > I updated all contrib makefiles so that they can be used either the
> > standard way after a configure, or the new way without needing a
> > configure but with an already installed postgreSQL. Just try them
> > with
> >
> > "cd contrib/foo ; make USE_PGXS=1 install"
> >
> > *AFTER* postgresql has been configure, compiled and installed. It
> > should be compiled and installed wrt to the first "pg_config" which
> > is found in the path.
>
> This is redundant. I think by now I'm looking for a patch that does not
> touch contrib at all (except perhaps contrib-global.mk).

I really just touch that file in contrib. The only other exceptions are
when other files were directly included or to reorder include wrt mqcro
definitions, as far as I can remember.

> Much of the trouble arises from being too clever around there. We're
> trying to allow external modules to build, not internal ones.

I really want to be able to install contribs as an afterthought and
without reconfiguring.

anyway, sorry I cannot really help as I m away from home.
Have a nice day,

--
Fabien Coelho - coelho(at)cri(dot)ensmp(dot)fr