Re: [HACKERS] How to make a patch?

From: Peter Eisentraut <e99re41(at)DoCS(dot)UU(dot)SE>
To: Chris <chris(at)bitmead(dot)com>
Cc: Postgres Hackers List <hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] How to make a patch?
Date: 2000-02-08 11:50:29
Message-ID: Pine.GSO.4.02A.10002081243340.12742-100000@Krokodil.DoCS.UU.SE
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 8 Feb 2000, Chris wrote:

> How do I make a patch that includes new files?
>
> Previously I was doing a cvs diff -R -N -c
> to make a patch, but this doesn't work for
> new files. I can't do cvs add, and using
> plain diff is near-impossible on a CVS directory.

Here is something that was recommended to me by Jan, and it seems a number
of other people follow a similar road.

When you checked out or updated your cvs copy and you want to start
working on something, make one copy like
$ cp -r pgsql pgsql.orig

Then run configure on that copy. Then copy this one like
$ cp -r pgsql.orig pgsql.work

Then work on this one. I find it occasionally useful to be able to do a
make install on the .orig tree as well do "see how it used to behave".
(You don't want to mess up your cvs tree for that.)

When you're done you create a patch between pgsql.orig and pgsql.work
using diff -c -r whatnot and send that in. Then you do cvs update again an
the game begins anew. This also has the advantage that if someone mangles
your patch slightly (such as running indent on it) you won't get funny
merge conflicts when you cvs update over your self-patched cvs tree.

--
Peter Eisentraut Sernanders vaeg 10:115
peter_e(at)gmx(dot)net 75262 Uppsala
http://yi.org/peter-e/ Sweden

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 2000-02-08 12:01:29 Re: [HACKERS] TODO item
Previous Message Hannu Krosing 2000-02-08 11:40:13 Re: [HACKERS] New Globe