Re: patch adding new regexp functions

From: Jeremy Drake <pgsql(at)jdrake(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Neil Conway <neilc(at)samurai(dot)com>, Mark Dilger <pgsql(at)markdilger(dot)com>
Subject: Re: patch adding new regexp functions
Date: 2007-02-18 20:03:35
Message-ID: Pine.BSO.4.64.0702181202050.18849@resin.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Sun, 18 Feb 2007, Peter Eisentraut wrote:

> Jeremy Drake wrote:
> > > As for the argument about array vs setof, I could see doing both to
> > > end the argument of which one is really superior for any particular
> > > problem.
> >
> > regexp_split(string text, pattern text[, flags text]) returns setof
> > text
> >
> > regexp_split_array(string text, pattern text[. flags text[, limit
> > int]]) returns text[]
>
> Since you are not splitting an array but returning an array, I would
> think that "regexp_split_to_array" would be better, and the other
> should then be "regexp_split_to_table".

OK

>
> But why does the second one have a limit and the first one doesn't? Is
> this because you rely on the LIMIT clause to do the same?

Yes

> Is there a
> guarantee that LIMIT on a table function makes a consistent order?

Why wouldn't it?

--
When you are in it up to your ears, keep your mouth shut.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-02-18 20:05:01 Re: Plan invalidation design
Previous Message Martijn van Oosterhout 2007-02-18 20:02:16 Re: RFC: Temporal Extensions for PostgreSQL

Browse pgsql-patches by date

  From Date Subject
Next Message Jeremy Drake 2007-02-18 23:10:51 Re: patch adding new regexp functions
Previous Message Nikolay Samokhvalov 2007-02-18 18:57:56 Re: patch for contrib/xml2