From: | Jeremy Drake <pgsql(at)jdrake(dot)com> |
---|---|
To: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Cc: | David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | patch adding new regexp functions |
Date: | 2007-02-09 03:22:58 |
Message-ID: | Pine.BSO.4.64.0702081918491.28908@resin.csoft.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Wed, 7 Feb 2007, Jeremy Drake wrote:
> Here is a patch to add these functions to core. Please take a look and
> let me know what you think. I had to jump through a bit of a hoop to
> avoid opr_sanity test from breaking, may not have done that right.
>
> Also, this patch allows regexp_replace to take more flags, since my two
> new functions needed flags also, I split flag parsing into a seperate
> function and made regexp_replace use it too. It also results that the
> error message for an invalid flag in regexp_replace changes, since it is
> now more generic as it is called from multiple functions.
>
> I still need to write documentation for the new functions before I
> consider the patch completed, but please take a look at the code and see
> if it is acceptable as I do not have any further changes planned for it.
I have added documentation for the functions in this patch. At this point
I am ready to submit this patch for the review and application process.
Please let me know if you find any issues with it.
Thank you
--
The trouble with being punctual is that nobody's there to appreciate
it.
-- Franklin P. Jones
Attachment | Content-Type | Size |
---|---|---|
regexp-split-matches-documented.patch.gz | application/octet-stream | 8.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-02-09 03:31:01 | Variable length varlena headers redux |
Previous Message | Tom Lane | 2007-02-09 03:15:26 | Re: [PATCHES] [pgsql-patches] Phantom Command IDs,updated patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2007-02-09 03:35:52 | Re: patch adding new regexp functions |
Previous Message | Tom Lane | 2007-02-09 03:15:26 | Re: [PATCHES] [pgsql-patches] Phantom Command IDs,updated patch |