Re: pg_dump --clean w/ <= 7.2 server

From: Kris Jurka <books(at)ejurka(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_dump --clean w/ <= 7.2 server
Date: 2004-06-24 20:31:58
Message-ID: Pine.BSO.4.56.0406241529150.30402@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, 24 Jun 2004, Tom Lane wrote:

> Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> >> When running pg_dump --clean against a server that doesn't have schemas
> >> the namespace is blank and ends up producing a dump full off things like:
> >>
> >> DROP TABLE "".tab;
>
> > Since the person is dumping using 7.5 pg_dump, presumably they will be
> > restoring to 7.5, and it should be:
>
> > DROP TABLE "public".tab;
>
> Possibly the most correct solution is to assign the name "public" to the
> dummy schema that pg_dump creates internally when talking to a pre-7.3
> server.

I was considering that they might want to restore the dump into another
schema and that would be easier with an unqualified name. I don't really
understand why the name needs to be fully qualified in the first place.

> I seem to recall that there was some reason for using "", but I don't
> recall what exactly.
>

It seems like the only possible reasons are deliberately making it fail or
just a lack of testing. There's no way it does anything useful.

Kris Jurka

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2004-06-24 20:44:02 Re: nested xacts and phantom Xids
Previous Message Tom Lane 2004-06-24 20:00:47 Re: Cancel/Kill backend functions -- docs