From: | Kris Jurka <books(at)ejurka(dot)com> |
---|---|
To: | Andy Zeneski <jaz(at)ofbiz(dot)org> |
Cc: | pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: Result Set Cursor Patch |
Date: | 2004-05-05 19:46:25 |
Message-ID: | Pine.BSO.4.56.0405051439020.4691@leary.csoft.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
On Wed, 5 May 2004, Andy Zeneski wrote:
> Kris,
>
> Here it is again, I think my IDE reformatted a few classes which caused
> this patch to be bigger then it needed to be. Here it is in its current
> state.
>
> If the formatting is major problem, I can attempt to reformat it to
> desired settings. I will need to know what the "preferred" way is. I've
> noticed there are several different formats used within these classes,
> I could easily run the tree though Jacobe and clean it up. However,
> that may be too big for the list. :)
The formatting is an issue. Yes, the code is formatted differently all
over the driver, but now is not the time to fix that. There are too many
outstanding patches that will conflict with these whitespace changes to
try and do something about that now. I aim to reindent/reformat at the
start of 7.5 beta when there shouldn't be many outstanding patches or
active development.
Also just trying to read your patch is difficult because it is impossible
to tell if a real change is mixed in with a whitespace change. Could you
resubmit this patch as just your changes.
Kris Jurka
From | Date | Subject | |
---|---|---|---|
Next Message | Barry Lind | 2004-05-05 20:15:07 | Re: Result Set Cursor Patch |
Previous Message | Barry Lind | 2004-05-05 19:38:24 | Re: German Special Chars (Umlaute) |