Re: [HACKERS] xlog.c.patch for cygwin port.

On Tue, 7 Mar 2000, Bruce Momjian wrote:

> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > This looks interesting. We could remove some of our ifwin cruft.
> >
> > I have been thinking for quite some time that most of the CYGWIN32
> > ifdefs represent very poor programming. Instead of zillions of
> >
> > #ifndef __CYGWIN32__
> > fd = open(filename, O_RDONLY, 0666);
> > #else
> > fd = open(filename, O_RDONLY | O_BINARY, 0666);
> > #endif
> >
> > we should have in one include file something like
>
> Do we ever assign a function pointer for open() anywhere. If so, the
> define will not work without some kind of wrapper, right?

Okay, I'm lost ... if we "#define OPEN_FLAGS .." and not the open itself,
why would we need some kind of wrapper?