Re: [HACKERS] pid_t define missing in include/miscadmin.h ...

From: The Hermit Hacker <scrappy(at)hub(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] pid_t define missing in include/miscadmin.h ...
Date: 2000-02-15 02:26:42
Message-ID: Pine.BSF.4.21.0002142222410.74045-100000@thelab.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 14 Feb 2000, Bruce Momjian wrote:

> pid_t is in /usr/include/sys/types.h. Maybe it is missing that include?

okay guys, I've had two answers so far that I would *really* have to be a
bad programmer not to have already checked :)

miscadmin.h doesn't include sys/types.h ... if I add sys/types.h to
miscadmin.h, it compiles fine ... the first place I looked was
/usr/include/sys/types.h for this ...

According to sources as of a couple of hours ago, sys/types.h isn't
included in anywhere I can think of off hand:

%ls
CVS config.h mb port storage
access config.h.in miscadmin.h postgres.h strdup.h
bootstrap dynloader.h nodes postgres_ext.h tcop
c.h executor optimizer regex utils
catalog lib os.h rewrite version.h
commands libpq parser rusagestub.h
version.h.in
%grep TYPE config.h
#define SOCKET_SIZE_TYPE size_t
%grep type.h *.h
%grep type.h */*.h
catalog/pg_type.h: * pg_type.h
catalog/pg_type.h: * $Id: pg_type.h,v 1.79 2000/01/26 05:57:59 momjian Exp
executor/spi.h:#include "catalog/pg_type.h"
parser/parse_coerce.h:#include "catalog/pg_type.h"
parser/parse_expr.h:#include "parser/parse_type.h"
parser/parse_type.h: * parse_type.h
parser/parse_type.h: * $Id: parse_type.h,v 1.12 2000/01/26 05:58:27
momjian Exp $
utils/acl.h: change the aclitem typlen in pg_type.h */
utils/inet.h: /* add IPV6 address type here */

And I've checked scansup.c itself, which includes <ctype.h>, but <ctype.h>
doesn't include <sys/types.h> either ... or does it on other ppls OSs?

Basically, where are other ppl getting <sys/types.h> included? :)

>
>
>
> > Okay, I may be missing something here, but:
> >
> > gmake[2]: Entering directory `/usr/local/pgsql/src/pgsql/src/backend/parser'
> > gcc -I../../include -I../../backend -O2 -m486 -pipe -Wall -Wmissing-prototypes -Wmissing-declarations -I.. -Wno-error -c scansup.c -o scansup.o
> > In file included from scansup.c:20:
> > ../../include/miscadmin.h:225: syntax error before `pid'
> > gmake[2]: *** [scansup.o] Error 1
> >
> > Looking at include/miscadmin.h:
> >
> > =========
> > extern int SetPidFile(pid_t pid);
> >
> > #endif /* MISCADMIN_H */
> > =========
> >
> > but I can't find anywhere that pid_t is defined, and the cvs logs don't
> > appear to indicate that anyone has touched that file in a few weeks ...
>
>
>
> >
>
>
> > So, am I missing something? This is using CVS source as of today, on
> > FreeBSD 4.0-CURRENT ...
> >
> > Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
> > Systems Administrator @ hub.org
> > primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org
> >
> >
> > ************
> >
>
>
> --
> Bruce Momjian | http://www.op.net/~candle
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 2000-02-15 02:44:49 Re: schema: pg_dump -s ipmeter (fwd)
Previous Message aubrey 2000-02-15 02:09:20 subscribe