Re: [PATCHES] bugs in version 6.5

I applied the ecpg, man and trace patches, but not the postgres one...is
this something something that one *is* working on?

>From what I can tell, in the logs, this was added to rev 1.112 of
postgres.c (the TRACE_PRETTY_PLAN stuff)...by Jan:

============================================================
revision 1.112
date: 1999/05/11 09:06:31; author: wieck; state: Exp; lines: +53 -19
Changed debug options:

-d4 now prints compressed trees from nodeToString()
-d5 prints pretty trees via nodeDisplay()

new pg_options: pretty_plan, pretty_parse, pretty_rewritten

Jan
============================================================

That was 3(?) weeks ago, and nobody has reported any problems with it so
far?

Jan? Comments?

On Fri, 4 Jun 1999, Massimo Dal Zotto wrote:

> Hi Hackers,
>
> I found some bugs in the latest snapshot (dated 19990606). I had some
> compilation errors which I have fixed with the following patches:
>
> ecpg.patch (wrong makefile expansion in some cases)
>
> the ecpg Makefiles use a variable DESTDIR which is never defined
> except by debian/rules makefile, in which case the ecpg makefiles
> expand wrong pathnames. If we want to support a DESTDIR root it
> must be done consistently in all the makefiles, not just in ecpg.
>
> man.patch (make inconsistency)
>
> the default target is 'install' instead of 'all'. So if you do a
> make without target you actually do a make install, which is not
> what one normally expects from a standard makefile.
>
> postgres.patch (compilation error)
>
> in postgres.c someone changed TRACE_PLAN to TRACE_PRETTY_PLAN
> which is not defined anywhere. Seems unfinished work in progress.
>
> trace.patch (compilation error)
>
> the gettimeofday doesn't compile under Linux with glibc2 because
> the DST_NONE constant is no more defined. It seems that this code
> (written by me) has always be wrong but for some reason working.
>
> --
> Massimo Dal Zotto
>
> +----------------------------------------------------------------------+
> | Massimo Dal Zotto email: dz(at)cs(dot)unitn(dot)it |
> | Via Marconi, 141 phone: ++39-0461534251 |
> | 38057 Pergine Valsugana (TN) www: http://www.cs.unitn.it/~dz/ |
> | Italy pgp: finger dz(at)tango(dot)cs(dot)unitn(dot)it |
> +----------------------------------------------------------------------+
>
>

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org