| From: | "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com> |
| Subject: | RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C |
| Date: | 2024-11-21 23:07:59 |
| Message-ID: | PH8PR11MB828629702AF626E7D740872BFB222@PH8PR11MB8286.namprd11.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I think it is in pretty good shape. After a read-through, the only thing that stands
> out to me is the difference in configure tests between autoconf and meson. I
> think we should consider picking one approach, although I'm not sure I have a
> strong preference.
Thanks for the review! We can actually leverage meson's built in option to check for a macro: cc.get_define('__SSE4_2__') != ''. This should keep the logic consistent across configure and meson.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Use-__attribute__-target-sse4.2-for-SSE42-CRC32C.patch | application/octet-stream | 11.2 KB |
| v4-0002-Use-consistent-logic-in-configure-and-meson-to-ge.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Giacchino, Luca | 2024-11-21 23:27:33 | SIMD optimization for list_sort |
| Previous Message | Tomas Vondra | 2024-11-21 23:05:40 | Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly |