RE: row filtering for logical replication

Hi,
Thank you for developing of the great feature.
If multiple tables are specified when creating a PUBLICATION,
is it supposed that the WHERE clause condition is given to only one table?
I attached the operation log below.

--- operation log ---
postgres=> CREATE TABLE data1(c1 INT PRIMARY KEY, c2 VARCHAR(10));
CREATE TABLE
postgres=> CREATE TABLE data2(c1 INT PRIMARY KEY, c2 VARCHAR(10));
CREATE TABLE
postgres=> CREATE PUBLICATION pub1 FOR TABLE data1,data2 WHERE (c1 < 1000);
CREATE PUBLICATION
postgres=> \d data1
Table "public.data1"
Column | Type | Collation | Nullable | Default
--------+-----------------------+-----------+----------+---------
c1 | integer | | not null |
c2 | character varying(10) | | |
Indexes:
"data1_pkey" PRIMARY KEY, btree (c1)
Publications:
"pub1"

postgres=> \d data2
Table "public.data2"
Column | Type | Collation | Nullable | Default
--------+-----------------------+-----------+----------+---------
c1 | integer | | not null |
c2 | character varying(10) | | |
Indexes:
"data2_pkey" PRIMARY KEY, btree (c1)
Publications:
"pub1" WHERE (c1 < 1000)

postgres=> SELECT prrelid, prqual FROM pg_publication_rel;
prrelid | prqual
---------+-----------------------------------------------------------------------------
16408 |
16413 | {OPEXPR :opno 97 :opfuncid 66 :opresulttype 16 :opretset false :opcol
lid 0 :inputcollid 0 :args ({VAR :varno 1 :varattno 1 :vartype 23 :vartypmod -1
:varcollid 0 :varlevelsup 0 :varnosyn 1 :varattnosyn 1 :location 53} {CONST :con
sttype 23 :consttypmod -1 :constcollid 0 :constlen 4 :constbyval true :constisnu
ll false :location 58 :constvalue 4 [ -24 3 0 0 0 0 0 0 ]}) :location 56}
(2 rows)

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Sent: Wednesday, February 23, 2022 11:06 AM
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: houzj(dot)fnst(at)fujitsu(dot)com; Peter Smith <smithpb2250(at)gmail(dot)com>; Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>; Greg Nancarrow <gregn4422(at)gmail(dot)com>; vignesh C <vignesh21(at)gmail(dot)com>; Ajin Cherian <itsajin(at)gmail(dot)com>; tanghy(dot)fnst(at)fujitsu(dot)com; Dilip Kumar <dilipbalaut(at)gmail(dot)com>; Rahila Syed <rahilasyed90(at)gmail(dot)com>; Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>; Önder Kalacı <onderkalaci(at)gmail(dot)com>; japin <japinli(at)hotmail(dot)com>; Michael Paquier <michael(at)paquier(dot)xyz>; David Steele <david(at)pgmasters(dot)net>; Craig Ringer <craig(at)2ndquadrant(dot)com>; Amit Langote <amitlangote09(at)gmail(dot)com>; PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication

On Tue, Feb 22, 2022 at 4:47 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Thu, Feb 17, 2022, at 3:36 AM, Amit Kapila wrote:
>
> As there is a new version, I would like to wait for a few more days
> before committing. I am planning to commit this early next week (by
> Tuesday) unless others or I see any more things that can be improved.
>
> Amit, I don't have additional comments or suggestions. Let's move on.
> Next topic. :-)
>

Pushed!

--
With Regards,
Amit Kapila.