Re: Error from the foreign RDBMS on a foreign table I have no privilege on

From: Phil Florent <philflorent(at)hotmail(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Error from the foreign RDBMS on a foreign table I have no privilege on
Date: 2022-06-10 16:20:09
Message-ID: PA4P191MB1600E873C2EAA79AD26F6751BAA69@PA4P191MB1600.EURP191.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
Thanks for your explanations.
Test case had no real-world logic anyway. It was just an oversight in a one-time use legacy migration script.
Regards,
Phil
________________________________
From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Sent: Friday, June 10, 2022 11:17:07 AM
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>; euler(at)eulerto(dot)com <euler(at)eulerto(dot)com>; philflorent(at)hotmail(dot)com <philflorent(at)hotmail(dot)com>; pgsql-hackers(at)lists(dot)postgresql(dot)org <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Error from the foreign RDBMS on a foreign table I have no privilege on

On Fri, 2022-06-10 at 17:17 +0900, Etsuro Fujita wrote:
> > I am not sure if it worth adding to the documentation. I would never have thought
> > of the problem if Phil hadn't brought it up. On the other hand, I was surprised
> > to learn that permissions aren't checked until the executor kicks in.
> > It makes sense, but some documentation might help others in that situation.
>
> +1 for adding such a document.
>
> > I'll gladly leave the decision to your judgement as a committer.
>
> IIRC, there are no reports about this from the postgres_fdw users, so
> my inclination would be to leave the documentation alone, for now.

I understand that you are for documenting the timing of permission checks,
but not in the postgres_fdw documentation. However, this is the only occasion
where the user might notice unexpected behavior on account of the timing of
permission checks. Other than that, I consider this below the threshold for
user-facing documentation.

I'm ok with just doing nothing here, I just wanted it discussed in public.

Yours,
Laurenz Albe

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema 2022-06-10 16:31:26 Support load balancing in libpq
Previous Message Stephen Frost 2022-06-10 16:20:00 Re: better page-level checksums