[PATCH] Change slash to backslash in make.bat

From: "zhangjie2(at)fujitsu(dot)com" <zhangjie2(at)fujitsu(dot)com>
To: "pgadmin-hackers(at)lists(dot)postgresql(dot)org" <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Cc: "zhangjie2(at)fujitsu(dot)com" <zhangjie2(at)fujitsu(dot)com>
Subject: [PATCH] Change slash to backslash in make.bat
Date: 2022-02-16 03:30:45
Message-ID: OSZPR01MB8564ABE286FC2A5CC67DFFACF9359@OSZPR01MB8564.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi, all

In windows, backslash should be used in the path.
In Linux, slash should be used in path.
But in pgadmin4\make.bat, slash is used in the path.
------------------------------------------------------------------------------------------------------------------------------------------------
FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "print('%APP_NAME%'.lower().replace(' ', ''))"') DO SET APP_SHORTNAME=%%G

FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_MAJOR=%%G
FOR /f "tokens=2 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_MINOR=%%G
FOR /f "tokens=3 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_REVISION=%%G
--------------------------------------------------------------------------------------------------------------------------------------------------
Although the slash does not affect the compilation, I think it is better to modify it.

Here is a patch for make.bat.
Please review.

Best Regards!
Zhang Jie

Attachment Content-Type Size
make.patch application/octet-stream 1.8 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2022-02-16 06:53:01 pgAdmin 4 commit: Added comments column for the functions collection no
Previous Message Akshay Joshi 2022-02-15 13:04:41 pgAdmin 4 commit: Rename the menu 'Disconnect Database' to 'Disconnect