RE: Handle infinite recursion in logical replication setup

From: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
Subject: RE: Handle infinite recursion in logical replication setup
Date: 2022-08-02 09:31:20
Message-ID: OSZPR01MB63109BB77F4117B5C56F1DB3FD9D9@OSZPR01MB6310.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 29, 2022 1:22 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Fri, Jul 29, 2022 at 8:31 AM Peter Smith <smithpb2250(at)gmail(dot)com>
> wrote:
> >
>
> Thanks for the comments, the attached v41 patch has the changes for the
> same.
>

Thanks for updating the patch.

A comment for 0002 patch.

In the example in section 31.11.4 (Generic steps for adding a new primary to an
existing set of primaries), I think there should be a Step-6, corresponding to
the steps mentioned before. And part of Step-5 should actually be part of
Step-6.

Regards,
Shi yu

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-08-02 10:21:13 Re: POC: GROUP BY optimization
Previous Message Richard Guo 2022-08-02 09:06:44 Fix obsoleted comments for function prototypes