| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Rename injection point names in test_aio |
| Date: | 2025-04-14 11:14:59 |
| Message-ID: | OSCPR01MB14966E0F977DFEAC871278056F5B32@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Michael,
> > I have no objections for the patch, but I feel there are no concrete naming rules
> > (I confused while creating patches).
>
> There has been a sort of implied rule in the code to use lower
> characters, with terms separated by dashes. Perhaps we could make
> that more official with an extra sentence in the docs about that.
Agreed.
> > Can we clarify that? E.g., first term should be a module or process,
> > or something like that.
>
> Not sure that it would be a good thing to put context-specific
> restrictions here.
My main concern is that in someday the name of injection points might be conflict,
and it might be painful to consider after the number of points is increased.
But it's OK to leave here now.
> Anyway, would you like to propose a patch for the documentation?
Sure, I did. Please see [1].
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2025-04-14 11:51:24 | Re: doc patch: clarify the naming rule for injection_points |
| Previous Message | jian he | 2025-04-14 11:09:45 | Re: support create index on virtual generated column. |