| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | RE: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-02-12 01:16:31 |
| Message-ID: | OSCPR01MB149668C438D124A4C2C7E7FCFF5FC2@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Shubham,
Thanks for updating the patch! I feel the patch has good shape. Here is a small comment.
```
+ /* Error if no databases were found on the source server */
+ if (num_rows == 0)
+ {
+ pg_log_error("no databases found on the source server");
+ pg_log_error_hint("Ensure that there are user-created databases on the source server.");
+ PQclear(res);
+ disconnect_database(conn, false);
+ exit(1);
+ }
```
I think the error message is not accurate. This error can happen when there are
user-created database but it is created as template. How about below:
```
- pg_log_error("no databases found on the source server");
- pg_log_error_hint("Ensure that there are user-created databases on the source server.");
+ pg_log_error("no convertable databases found on the source server");
+ pg_log_error_hint("Ensure that there are non-template and connectable databases on the source server.");
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2025-02-12 01:20:53 | Re: [PATCH] Optionally record Plan IDs to track plan changes for a query |
| Previous Message | Melanie Plageman | 2025-02-12 01:10:01 | Re: Confine vacuum skip logic to lazy_scan_skip |