RE: long-standing data loss bug in initial sync of logical replication

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Nitin Motiani <nitinmotiani(at)google(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: RE: long-standing data loss bug in initial sync of logical replication
Date: 2025-03-17 01:22:59
Message-ID: OSCPR01MB149668597B9593D9EFCC5DE68F5DF2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Amit,

> IIUC, workloads C and D will have regression in back branches, and
> HEAD will have regression only for workload D. We have avoided
> workload C regression in HEAD via commits 7c99dc587a and 3abe9dc188.

Right.

> We can backpatch those commits if required, but I think it is better
> not to do those as scenarios C and D won't be that common, and we
> should go ahead with the fix as it is. In the future, if we get any
> way to avoid regression due to scenario-D, then we can do that for the
> HEAD branch.

OK, let me share patched for back branches. Mostly the same fix patched as master
can be used for PG14-PG17, like attached. Regarding the PG13, it cannot be applied
as-is thus some adjustments are needed. I will share it in upcoming posts.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
v18_REL_14-0001-Distribute-invalidatons-if-change-in-cata.patch application/octet-stream 14.0 KB
v18_REL_15-0001-Distribute-invalidatons-if-change-in-cata.patch application/octet-stream 15.7 KB
v18_REL_16-0001-Distribute-invalidatons-if-change-in-cata.patch application/octet-stream 15.6 KB
v18_REL_17-0001-Distribute-invalidatons-if-change-in-cata.patch application/octet-stream 15.6 KB
v18-0001-Distribute-invalidatons-if-change-in-catalog-tab.patch application/octet-stream 15.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Steven Niu 2025-03-17 01:43:26 Re: Not-terribly-safe checks for CRC intrinsic support
Previous Message Sungwoo Chang 2025-03-17 00:55:07 Re: dsm_registry: Add detach and destroy features