| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "ShlokKumar(dot)Kyal(at)fujitsu(dot)com" <ShlokKumar(dot)Kyal(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | RE: Selectively invalidate caches in pgoutput module |
| Date: | 2025-03-12 12:15:58 |
| Message-ID: | OSCPR01MB1496634BCDF6475BF0AC6658BF5D02@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
> Thanks, the patch looks mostly good to me. I have made few cosmetic
> changes in the attached and combined both the patches.
Thanks, it looks good to me.
> The existing
> Alter Publication ... Rename tests don't test invalidations arising
> from that command. As this patch changes that code path, it would be
> good to add a few tests for the same. We can add one for individual
> relations and another for ALL Tables publication.
I created new patch which adds a test code. I added in 007_ddl.pl, but I feel
it is OK to introduce new test file. How do you think?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Avoid-invalidating-all-RelationSyncCache-entries.patch | application/octet-stream | 15.5 KB |
| v12-0002-Add-testcase.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2025-03-12 12:26:55 | Re: Question about duplicate JSONTYPE_JSON check |
| Previous Message | Alvaro Herrera | 2025-03-12 12:05:45 | Re: Test to dump and restore objects left behind by regression |