| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 'vignesh C' <vignesh21(at)gmail(dot)com> |
| Subject: | RE: pg_recvlogical requires -d but not described on the documentation |
| Date: | 2025-03-19 02:32:26 |
| Message-ID: | OSCPR01MB149660CCE2ADCC54A11F57E09F5D92@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
> It looks like commit 0c013e08cfb introduced a bug that causes "pg_recvlogical
> --drop-slot"
> without --dbname to check whether it's connected to a specific database and fail
> if it's not.
>
> This commit was added before 9.5, while pg_recvlogical was introduced in 9.4. On
> my env,
> "pg_recvlogical --drop-slot" without --dbname worked as expected in 9.4 but
> started
> failing in 9.5 or later.
>
> So, I think the proper fix is to avoid raising a fatal error even when not connected
> to
> a specific database in --drop-slot action.
+1. I created patch to fix it. 0001 was completely same as you did.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-doc-Clarify-required-options-for-each-action-in-p.patch | application/octet-stream | 3.1 KB |
| v3-0002-pg_recvlogical-allow-working-without-dbname-while.patch | application/octet-stream | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-03-19 02:33:00 | Re: Update Unicode data to Unicode 16.0.0 |
| Previous Message | Michael Paquier | 2025-03-19 02:28:54 | Re: Add Pipelining support in psql |