| From: | "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'Michael Paquier' <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE |
| Date: | 2021-08-25 05:10:57 |
| Message-ID: | OSBPR01MB42149653BC0AB0A49D23C1B8F2C69@OSBPR01MB4214.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I find in ecpg.header, the source:
> if (connection)
> if (connection && strcmp(ptr->connection, connection) != 0)
The first if statement is useless. And in fix-ecpg-tests.patch:
>- if (connection)
>- mmerror(PARSE_ERROR, ET_WARNING, "connection %s is overwritten to %s.", connection, ptr->connection);
>+ if (connection && strcmp(ptr->connection, connection) != 0)
>+ mmerror(PARSE_ERROR, ET_WARNING, "declare statement %s using connection %s overwritten to connection %s.",
>+ name, connection, ptr->connection);
The patch seems right.
Delete first if statement, patch attached.
Regards,
Shenhao Wang
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-delete-dup-if-statement.patch | application/octet-stream | 900 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2021-08-25 05:21:40 | Re: replay of CREATE TABLESPACE eats data at wal_level=minimal |
| Previous Message | Soumyadeep Chakraborty | 2021-08-25 04:51:25 | Re: Unnecessary delay in streaming replication due to replay lag |