| From: | "Chiranmoy(dot)Bhattacharya(at)fujitsu(dot)com" <Chiranmoy(dot)Bhattacharya(at)fujitsu(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, John Naylor <johncnaylorls(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Devanga(dot)Susmitha(at)fujitsu(dot)com" <Devanga(dot)Susmitha(at)fujitsu(dot)com>, "Ragesh(dot)Hajela(at)fujitsu(dot)com" <Ragesh(dot)Hajela(at)fujitsu(dot)com> |
| Subject: | Re: [PATCH] Hex-coding optimizations using SVE on ARM. |
| Date: | 2025-01-22 10:58:09 |
| Message-ID: | OSBPR01MB2664A733AFB69AB1A7A43CC297E12@OSBPR01MB2664.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> The approach looks generally reasonable to me, but IMHO the code needs
much more commentary to explain how it works.
Added comments to explain the SVE implementation.
> I would be interested to see how your bytea test compares with the
improvements added in commit e24d770 and with sending the data in binary.
The following are the bytea test results with commit e24d770.
The same query and tables were used.
With commit e24d770:
Query exec time: 2.324 sec
hex_encode function time: 0.72 sec
Pre-commit e24d770:
Query exec time: 2.858 sec
hex_encode function time: 1.228 sec
SVE patch:
Query exec time: 1.654 sec
hex_encode_sve function time: 0.085 sec
> The functions that test the length before potentially calling a function
> pointer should probably be inlined (see pg_popcount() in pg_bitutils.h).
> I wouldn't be surprised if some compilers are inlining this stuff
> already, but it's probably worth being explicit about it.
Should we implement an inline function in "utils/builtins.h", similar to
pg_popcount()? Currently, we have not modified the header file, everything
is statically implemented in encode.c.
---
Chiranmoy
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-01-22 11:01:32 | Re: [PATCH] Fix a tiny typo in the documentation |
| Previous Message | Shubham Khanna | 2025-01-22 10:53:13 | Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility. |