| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Ilyasov Ian <ianilyasov(at)outlook(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled |
| Date: | 2024-05-15 13:35:48 |
| Message-ID: | OSBPR01MB2552E50362BAE4857B05F25CF5EC2@OSBPR01MB2552.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit, Ian,
> I guess it could be more work if we want to enhance the test for
> ERRORs other than the primary key violation. One simple fix is to
> update the log_offset to the location of the LOG after successful
> replication of un-conflicted data. For example, the Log location after
> we execute the below line in the test:
>
> # Check replicated data
> my $res =
> $node_subscriber->safe_psql('postgres', "SELECT
> count(*) FROM tbl");
> is($res, $expected, $msg);
I made a patch for confirmation purpose. This worked well on my environment.
Ian, how about you?
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/
| Attachment | Content-Type | Size |
|---|---|---|
| fix_029.diff | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-05-15 13:38:34 | Re: libpq compression (part 3) |
| Previous Message | David G. Johnston | 2024-05-15 13:35:31 | Re: Postgres and --config-file option |