From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
---|---|
To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Subject: | RE: pg_createsubscriber: drop pre-existing subscriptions from the converted node |
Date: | 2024-06-27 06:17:18 |
Message-ID: | OSBPR01MB25528CE9E000B081BDBAE59EF5D72@OSBPR01MB2552.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dear Amit, Vingesh,
Thanks for giving comments!
> It seems disabling subscriptions on the primary can make the primary
> stop functioning for some duration of time. I feel we need some
> solution where after converting to subscriber, we disable and drop
> pre-existing subscriptions. One idea could be that we use the list of
> new subscriptions created by the tool such that any subscription not
> existing in that list will be dropped.
Previously I avoided coding like yours, because there is a room that converted
node can connect to another publisher. But per off-list discussion, we can skip
it by setting max_logical_replication_workers = 0. I refactored with the approach.
Note that the GUC is checked at verification phase, so an attribute is added to
start_standby_server() to select the workload.
Most of comments by Vignesh were invalidated due to the code change, but I hoped
I checked your comments were not reproduced. Also, 0001 was created to remove an
unused attribute.
> Shouldn't this be an open item for PG17?
Added this thread to wikipage.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/
Attachment | Content-Type | Size |
---|---|---|
v2-0001-pg_createsubscriber-remove-unused-attribute.patch | application/octet-stream | 834 bytes |
v2-0002-pg_createsubscriber-Drop-pre-existing-subscriptio.patch | application/octet-stream | 10.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | jian he | 2024-06-27 06:25:25 | Re: pgsql: Add more SQL/JSON constructor functions |
Previous Message | Hannu Krosing | 2024-06-27 06:12:20 | Re: Adminpack removal |