| From: | "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com> |
|---|---|
| To: | 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
| Cc: | Matthieu Garrigues <matthieu(dot)garrigues(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: PATCH: Batch/pipelining support for libpq |
| Date: | 2021-03-03 07:07:59 |
| Message-ID: | OSBPR01MB23415F455B2532A4E83975B3EF989@OSBPR01MB2341.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 17, 2021 8:14 AM (JST), Alvaro Herrera wrote:
Hi Alvaro,
> Here's a new version, where I've renamed everything to "pipeline". I think the
> docs could use some additional tweaks now in order to make a coherent
> story on pipeline mode, how it can be used in a batched fashion, etc.
I tried applying this patch to test it on top of Iwata-san's libpq trace log [1].
In my environment, the compiler complains.
It seems that in libpqwalreceiver.c: libpqrcv_exec()
the switch for PQresultStatus needs to handle the
cases for PGRES_PIPELINE_END and PGRES_PIPELINE_ABORTED too.
switch (PQresultStatus(pgres))
{
...
Case PGRES_PIPELINE_ABORTED:
...
Case PGRES_PIPELINE_ END:
Regards,
Kirk Jamison
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2021-03-03 07:22:44 | Re: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Mohamed Insaf | 2021-03-03 06:58:04 | Why OR-clauses not getting copied into baserestrictinfo of another table whose columns are in the same EquivalenceClass? |