| From: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
|---|---|
| To: | 'Tomas Vondra' <tomas(dot)vondra(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: batch fdw insert bug (Postgres 14) |
| Date: | 2021-05-10 01:19:33 |
| Message-ID: | OSAPR01MB29770C911D80E979CFC2B7EBFE549@OSAPR01MB2977.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
> I think the simplest fix is simply to pstrdup() the query when building
> fmstate in create_foreign_modify. We've already been doing that for
> orig_query anyway. That seems cleaner than printing the last query we
> build (which would be confusing I think).
>
> I've pushed a fix doing that. We only need that for INSERT queries, and
> we might even restrict that to cases with batching if needed.
Thank you for investigating and committing the fix. (I'm relieved that the feature was not reverted.)
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2021-05-10 01:26:52 | RE: Inaccurate error message when set fdw batch_size to 0 |
| Previous Message | Michael Paquier | 2021-05-10 00:41:51 | Re: JSON doc example (matchiness) |