| From: | "tachikake(dot)ayaki(at)fujitsu(dot)com" <tachikake(dot)ayaki(at)fujitsu(dot)com> | 
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> | 
| Subject: | Fix wrong syntax about CREATE_REPLICATION_SLOT | 
| Date: | 2022-10-12 08:33:43 | 
| Message-ID: | OSAPR01MB2852607B2329FFA27834105AF1229@OSAPR01MB2852.jpnprd01.prod.outlook.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Hi hackers,
A minor bug was found in the "CREATE_REPLICATION_SLOT" syntax.
It is in protocol.sgml at line 1990.
The current syntax written in it is as follows,
CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL } [ ( option [, ...] ) ]
However, when I executed a command as follows, that became syntax error.
CREATE_REPLICATION_SLOT tachi LOGICAL;
ERROR:  syntax error
To use LOGICAL, output_plugin must be required.
Correct syntax is as follows.
CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL output_plugin } [ ( option [, ...] ) ]
PSA patch to fix it.
Note that version 15 must also be fixed.
Best Regards,
Ayaki Tachikake
FUJITSU LIMITED
| Attachment | Content-Type | Size | 
|---|---|---|
| doc.patch | application/octet-stream | 1.1 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-10-12 08:38:25 | Re: create subscription - improved warning message | 
| Previous Message | Michael Paquier | 2022-10-12 08:33:42 | Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc? |