| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 'vignesh C' <vignesh21(at)gmail(dot)com> |
| Subject: | RE: pg_recvlogical requires -d but not described on the documentation |
| Date: | 2025-03-21 01:12:26 |
| Message-ID: | OS7PR01MB14968005B4C609E0345094C9EF5DB2@OS7PR01MB14968.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
> Thanks for the patch! It looks good to me.
>
> I'm considering whether to back-patch these changes to older versions.
> Since pg_recvlogical --drop-slot worked without --dbname in 9.4
> but started failing unintentionally in 9.5, it could be considered a bug.
> However, this behavior has existed for a long time without complaints or
> bug reports, and there was no clear documentation stating that
> --drop-slot should work without --dbname.
>
> Given this, I think that also we could treat it as not a bug and apply
> the change only to the master branch. What do you think should we
> back-patch it as a bug fix or apply it only to master?
Personally considered, such a long-standing but harmless bug can be regarded as
the specification. So, I vote that this is an enhancement and be applied only to
master.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2025-03-21 01:38:58 | Re: Allow default \watch interval in psql to be configured |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-03-21 01:07:06 | RE: doc patch: wrong descriptions for dropping replication slots |