| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Improve eviction algorithm in ReorderBuffer |
| Date: | 2024-03-29 11:48:29 |
| Message-ID: | OS7PR01MB1208188BA629D7B35247E5209F53A2@OS7PR01MB12081.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Sawada-san,
> Agreed.
>
> I think the patch is in good shape. I'll push the patch with the
> suggestion next week, barring any objections.
Thanks for working on this. Agreed it is committable.
Few minor comments:
```
+ * Either txn or change must be non-NULL at least. We update the memory
+ * counter of txn if it's non-NULL, otherwise change->txn.
```
IIUC no one checks the restriction. Should we add Assert() for it, e.g,:
Assert(txn || change)?
```
+ /* make sure enough space for a new node */
...
+ /* make sure enough space for a new node */
```
Should be started with upper case?
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-03-29 12:00:00 | Re: To what extent should tests rely on VACUUM ANALYZE? |
| Previous Message | Philip Warner | 2024-03-29 11:47:24 | Re: Logical replication failure modes |