RE: drop tablespace failed when location contains .. on win32

From: "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>
Cc: "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: drop tablespace failed when location contains .. on win32
Date: 2021-09-26 08:40:15
Message-ID: OS3PR01MB71599B537F68956616FCC4BAF2A69@OS3PR01MB7159.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> -----Original Message-----
> From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
> Sent: Monday, September 13, 2021 4:36 PM
> To: michael(at)paquier(dot)xyz

> Mmm. I haven't thought that so seriously, but '/hoge/foo/bar' doesn't
> seem to be an absolute path on Windows since it lacks
> "<dirver-letter>:" or "//hostname" part. If we're on drive D:,
> "/Program\ Files" doesn't mean "C:\Program\ Files" but "D:\Program\
> Files".

I don't know this. After some test, I think it's better to consider '/hoge/foo/bar'
as a absolute path.

0001 and 0002 are the are the bugfix patches.
0003 is the test patch what I have tested on Linux and Windows.

Waiting for some comment.
Add to the commitfest: https://commitfest.postgresql.org/35/3331/

Regards,
Shenhao Wang

Attachment Content-Type Size
0002-v1-remove-function-path_contains_parent_reference.patch application/octet-stream 5.6 KB
0003-v1-some-canonicalize_path-tests.patch application/octet-stream 32.1 KB
0001-v1-make-canonicalize_path-remove-all-.-in-path.patch application/octet-stream 6.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2021-09-26 08:56:57 Re: BUG #16583: merge join on tables with different DB collation behind postgres_fdw fails
Previous Message Fabien COELHO 2021-09-26 05:55:22 Re: rand48 replacement