RE: Data is copied twice when specifying both child and parent table in publication

From: "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>
Subject: RE: Data is copied twice when specifying both child and parent table in publication
Date: 2023-02-08 03:51:08
Message-ID: OS3PR01MB62758DFA4FE5BFA7CA0815329ED89@OS3PR01MB6275.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 8, 2023 4:29 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2022-11-16 08:58:31 +0000, wangw(dot)fnst(at)fujitsu(dot)com wrote:
> > Attach the new patch set.
>
> This patch causes several of the tests to fail. See e.g.:
>
> https://cirrus-ci.com/task/6587624765259776
>
> Most of the failures appear to be due to the main regression tests failing:
> https://api.cirrus-
> ci.com/v1/artifact/task/6587624765259776/testrun/build/testrun/regress/regres
> s/regression.diffs
>
> diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/publication.out
> /tmp/cirrus-ci-build/build/testrun/regress/regress/results/publication.out
> --- /tmp/cirrus-ci-build/src/test/regress/expected/publication.out 2023-02-
> 07 20:19:34.318018729 +0000
> +++ /tmp/cirrus-ci-build/build/testrun/regress/regress/results/publication.out
> 2023-02-07 20:22:53.545223026 +0000
> @@ -1657,7 +1657,7 @@
> SELECT * FROM pg_publication_tables;
> pubname | schemaname | tablename | attnames | rowfilter
> ---------+------------+------------+----------+-----------
> - pub | sch2 | tbl1_part1 | {a} |
> + pub | sch2 | tbl1_part1 | |
> (1 row)
>
> DROP PUBLICATION pub;

Thanks for your kind reminder and analysis.

I think this failure is caused by the recently commit (b7ae039) in the current
HEAD. Rebased the patch set and attach them.

Regards,
Wang Wei

Attachment Content-Type Size
HEAD_v16-0001-Fix-data-replicated-twice-when-specifying-publis.patch application/octet-stream 22.9 KB
HEAD_v16-0002-Add-clarification-for-the-behaviour-of-the-publi.patch application/octet-stream 2.4 KB
REL15_v16-0001-Fix-data-replicated-twice-when-specifying-publis_patch application/octet-stream 8.6 KB
REL14_v16-0001-Fix-data-replicated-twice-when-specifying-publis_patch application/octet-stream 5.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-02-08 04:12:15 Re: Worth using personality(ADDR_NO_RANDOMIZE) for EXEC_BACKEND on linux?
Previous Message Tom Lane 2023-02-08 03:38:24 Re: Missing TAG for FEB (current) Minor Version Release