| From: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Euler Taveira <euler(at)eulerto(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | RE: Logical replication timeout problem |
| Date: | 2022-04-21 09:50:57 |
| Message-ID: | OS3PR01MB62754DF6581A3904A78A37CB9EF49@OS3PR01MB6275.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 21, 2022 at 10:15 AM I wrote:
> The comments by Sawada-San sound reasonable to me.
> After doing check, I found that padding in HEAD is the same as in REL14.
> So I change the approach of patch for HEAD just like the patch for REL14.
Also attach the back-branch patches for REL10~REL13.
(REL12 and REL11 patch are the same, so only post one patch for these two
branches.)
The patch for HEAD:
HEAD_v18-0001-Fix-the-logical-replication-timeout-during-large.patch
The patch for REL14:
REL14_v2-0001-Fix-the-logical-replication-timeout-during-large-.patch
The patch for REL13:
REL13_v1-0001-Fix-the-logical-replication-timeout-during-large-.patch
The patch for REL12 and REL11:
REL12-REL11_v1-0001-Fix-the-logical-replication-timeout-during-large-.patch
The patch for REL10:
REL10_v1-0001-Fix-the-logical-replication-timeout-during-large-.patch
BTW, after doing check, I found that padding in REL11~REL13 are similar as HEAD
and REL14 (7 bytes padding after fast_forward). But in REL10, the padding is
different. There are three parts padding behind the following member variables:
- 4 bytes after options
- 6 bytes after prepared_write
- 4 bytes after write_xid
So, in the patches for branches REL11~HEAD, I add the new variable after
fast_forward. In the patch for branch REL10, I add the new variable after
prepared_write.
For each version, the size of the structure does not change after applying the
patch.
Regards,
Wang wei
| Attachment | Content-Type | Size |
|---|---|---|
| HEAD_v18-0001-Fix-the-logical-replication-timeout-during-large.patch | application/octet-stream | 13.1 KB |
| REL14_v2-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 13.3 KB |
| REL13_v1-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 8.8 KB |
| REL12-REL11_v1-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 8.7 KB |
| REL10_v1-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-04-21 11:43:10 | Re: Dump/Restore of non-default PKs |
| Previous Message | Amit Kapila | 2022-04-21 09:41:00 | Re: Data is copied twice when specifying both child and parent table in publication |