| From: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Confused comment about drop replica identity index |
| Date: | 2021-12-21 01:31:42 |
| Message-ID: | OS3PR01MB62752D978D41EF6E0668AAD19E7C9@OS3PR01MB6275.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 20, 2021 at 19:11PM, Michael Paquier wrote:
> That's mostly fine. I have made some adjustments as per the attached.
Thanks for reviewing.
> + The default for non-system tables. Records the old values of the columns
> + of the primary key, if any. The default for non-system tables.
> The same sentence is repeated twice.
>
> + Records no information about the old row.(This is the
> default for system tables.)
> For consistency with the rest, this could drop the parenthesis for the second
> sentence.
>
> + <term><literal>USING INDEX index_name</literal></term>
> This should use <replaceable> as markup for index_name.
The change looks good to me.
Regards,
Wang wei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-12-21 01:50:07 | Re: Emit a warning if the extension's GUC is set incorrectly |
| Previous Message | Peter Geoghegan | 2021-12-21 01:17:26 | Re: do only critical work during single-user vacuum? |