| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: row filtering for logical replication |
| Date: | 2021-12-02 03:32:10 |
| Message-ID: | OS0PR01MB6113AEC93C38423FCBB87E47FB699@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, December 2, 2021 5:21 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> PSA the v44* set of patches.
>
Thanks for the new patch. Few comments:
1. This is an example in publication doc, but in fact it's not allowed. Should we
change this example?
+CREATE PUBLICATION active_departments FOR TABLE departments WHERE (active IS TRUE);
postgres=# CREATE PUBLICATION active_departments FOR TABLE departments WHERE (active IS TRUE);
ERROR: invalid publication WHERE expression for relation "departments"
HINT: only simple expressions using columns, constants and immutable system functions are allowed
2. A typo in 0002 patch.
+ * drops such a user-defnition or if there is any other error via its function,
"user-defnition" should be "user-definition".
Regards,
Tang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-12-02 03:34:39 | Re: GUC flags |
| Previous Message | Justin Pryzby | 2021-12-02 03:31:45 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |