RE: Remove double check when field_name is not NULL in be-secure-openssl.c

From: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "magnus(at)hagander(dot)net" <magnus(at)hagander(dot)net>
Subject: RE: Remove double check when field_name is not NULL in be-secure-openssl.c
Date: 2021-09-15 10:01:20
Message-ID: OS0PR01MB6113A554F0DE368276D67FBFFBDB9@OS0PR01MB6113.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wednesday, September 15, 2021 6:54 PM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>The proposal removes a second == NULL check on field_name in the case where
>OBJ_nid2sn() returns an ASN1_OBJECT. This is not in a hot path, and the ASM
>generated is equal under optimization levels so I don't see the value in the
>code churn and the potential for collisions during backpatching around here.

Thanks for your kindly explanation.
Got it.

Regards,
Tang

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marcos Pegoraro 2021-09-15 10:28:37 Trigger position
Previous Message Daniel Gustafsson 2021-09-15 09:53:50 Re: Remove double check when field_name is not NULL in be-secure-openssl.c