RE: "ERROR: deadlock detected" when replicating TRUNCATE

From: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: "ERROR: deadlock detected" when replicating TRUNCATE
Date: 2021-05-20 07:16:13
Message-ID: OS0PR01MB61139DED7B453067B3F664B8FB2A9@OS0PR01MB6113.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thursday, May 20, 2021 3:05 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Okay, I have prepared the patches for all branches (11...HEAD). Each
> version needs minor changes in the test, the code doesn't need much
> change. Some notable changes in the tests:
> 1. I have removed the conf change for max_logical_replication_workers
> on the publisher node. We only need this for the subscriber node.
> 2. After creating the new subscriptions wait for initial
> synchronization as we do for other tests.
> 3. synchronous_standby_names need to be reset for the previous test.
> This is only required for HEAD.
> 4. In PG-11, we need to specify the application_name in the connection
> string, otherwise, it took the testcase file name as application_name.
> This is the same as other tests are doing in PG11.
>
> Can you please once verify the attached patches?

I have tested your patches for all branches(11...HEAD). All of them passed. B.T.W, I also confirmed that the bug exists in these branches without your fix.

The changes in tests LGTM.
But I saw whitespace warnings when applied the patches for PG11 and PG12, please take a look at this.

Regards
Tang

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-05-20 08:14:10 Re: Inaccurate error message when set fdw batch_size to 0
Previous Message Nitin Jadhav 2021-05-20 06:51:12 Re: Query about time zone patterns in to_char